Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36168 )
Change subject: soc/intel/common: Make native and FSP-T CAR init mutually exclusive ......................................................................
Patch Set 9: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/36168/6/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36168/6/src/soc/intel/common/block/... PS6, Line 1: ifeq ($(CONFIG_FSP_CAR),n)
Ack, but it's y if selected ;) you could check for an empty string, or […]
Thank you, it looks much better, imho.
https://review.coreboot.org/c/coreboot/+/36168/9/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36168/9/src/soc/intel/common/block/... PS9, Line 9: postcar-$(CONFIG_SOC_INTEL_COMMON_BLOCK_CPU) += cpulib.c Please mention this drop in the commit message.
https://review.coreboot.org/c/coreboot/+/36168/9/src/soc/intel/common/block/... PS9, Line 2: bootblock-$(CONFIG_SOC_INTEL_COMMON_BLOCK_CPU)+= car/cache_as_ram_fsp.S missing space before +=