Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Sathya Prakash M R, Patrick Rudolph.
Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54716 )
Change subject: mb/google/brya: Add firmware configuration probing for audio
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/brya/variants/brya0/fw_config.c:
https://review.coreboot.org/c/coreboot/+/54716/comment/641f3387_70f672cb
PS7, Line 82: BS_PRE_DEVICE
Is there a reason you moved this to PRE_DEVICE ? Volteer used BS_DEV_ENABLE, and I don't see why tha […]
Hi Tim,
we are working on the BT offload changes on top of current patch, which is under verification.
I can revert this to BS_DEV_ENABLE, if it is better to make change in the corresponding patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54716
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f159442516830f9d304d78c83f070e4fcff4a37
Gerrit-Change-Number: 54716
Gerrit-PatchSet: 7
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 01 Jun 2021 15:36:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment