[coreboot-gerrit] Change in ...coreboot[master]: mb/qemu-{i440fx,q35}: Use POSTCAR stage to load the ramstage

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30499 )

Change subject: mb/qemu-{i440fx,q35}: Use POSTCAR stage to load the ramstage
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/30499/3/src/mainboard/emulation/qemu-i440fx/... 
File src/mainboard/emulation/qemu-i440fx/romstage.c:

https://review.coreboot.org/#/c/30499/3/src/mainboard/emulation/qemu-i440fx/... 
PS3, Line 44: 	postcar_frame_add_mtrr(&pcf, 0, qemu_get_memory_size() * KiB,
> You need to honour MTRR alignment requirements here. Sort of. […]

Agree. They are used in the following patches to setup correct page tables for x86_64. I'll add a comment and explain why they are added and move them to the follow on patches.