Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48632 )
Change subject: soc/amd/picasso: Fix ACPI PCI routing table
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48632/4/src/soc/amd/picasso/pcie_gp...
File src/soc/amd/picasso/pcie_gpp.c:
https://review.coreboot.org/c/coreboot/+/48632/4/src/soc/amd/picasso/pcie_gp...
PS4, Line 51: pci_routing->intx[i] - 'A'
The pci_routing_table is self contained, so I didn't see a reason to add additional validation. […]
ok
https://review.coreboot.org/c/coreboot/+/48632/4/src/soc/amd/picasso/pcie_gp...
PS4, Line 106: 0x0000FFFF
shouldn't this rather be:
PCI_SLOT(dev->path.pci.devfn) << 16 | 0xffff
the spec says that the lower 2 bytes need to be ffff and the rest needs to have the format used in _ADR where the device number is encoded in the upper 2 bytes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48632
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b2cce9913081d5cd456043ba619a79c1dfd4a8e
Gerrit-Change-Number: 48632
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 06 Jan 2021 01:29:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment