Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36879 )
Change subject: sb/intel/common: Add the SOUTHBRIDGE_INTEL_COMMON_USBDEBUG Kconfig symbol ......................................................................
Patch Set 2:
(1 comment)
This breaks EHCI debug on every Intel board.
Fixed a typo. Hope it is better now
I fail to so see how it improves the situation. Now you just replace one Kconfig symbol by another.
Mike, if you make it `default y` platforms not using it would have to opt-out. If `default n`, platforms would have to opt-in to make use of it. The latter seems correct and is what Arthur does.
I just tested it with the typo corrected, fails for G505s with the same error as before.
https://review.coreboot.org/c/coreboot/+/36879/2/src/southbridge/intel/commo... File src/southbridge/intel/common/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36879/2/src/southbridge/intel/commo... PS2, Line 31: CONFIG_SOUTHBRIDGE_INTEL_USBDEBUG You named it differently in the Kconfig.