This breaks EHCI debug on every Intel board.

Fixed a typo. Hope it is better now

I fail to so see how it improves the situation. Now you just replace one Kconfig symbol by another.

Mike, if you make it `default y` platforms not using it would have to
opt-out. If `default n`, platforms would have to opt-in to make use
of it. The latter seems correct and is what Arthur does.

I just tested it with the typo corrected, fails for G505s with the
same error as before.

View Change

1 comment:

To view, visit change 36879. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b58aa4d9c678b125a5b239f41e97b5c4a9d12fe
Gerrit-Change-Number: 36879
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 16 Nov 2019 11:07:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment