[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/braswell: add default option to use public FSP

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32381 )

Change subject: soc/intel/braswell: add default option to use public FSP
......................................................................

Patch Set 12:

(1 comment)
> Patch Set 8:
>
> Hmmm, it doesn't build? I have no idea why it does
> try to add the file for Cyan variants (and only if
> not building for cros???).
>
> The cbfstool issue seems to be fixed with FSP_LOC
> 0xfff2000 (no idea why we have to specify this when
> it depends on the binary).

https://review.coreboot.org/#/c/32381/10/src/drivers/intel/fsp1_1/Kconfig 
File src/drivers/intel/fsp1_1/Kconfig:

https://review.coreboot.org/#/c/32381/10/src/drivers/intel/fsp1_1/Kconfig@57 
PS10, Line 57: This must match the
             : 	  value that is set in the FSP binary
> I checked the current binary with BCT, it's 0x0xfff20000, so I'll adjust based on use of CONFIG_USE_ […]

This base if for the non-SecureBoot only!
The SecureBootEnabled default FSP_LOC is 0xfff9c000.