[coreboot-gerrit] Change in ...coreboot[master]: southbridge/intel/common/smbus.c: Add support for I2C commands

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30800 )

Change subject: southbridge/intel/common/smbus.c: Add support for I2C commands
......................................................................

Patch Set 3:

Ok. I just wanted to be sure about the command format the slave side expects to see.

Unless you really want to, you don't need to rebase your changes. I think it's more valuable if you are available for testing the new code I push.

The trouble here is the lack of symmetry on i2c_block_read() and i2c_block_write(), as they use different command code fields on the host controller.