Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34173 )
Change subject: siemens/mc_bdx1: increase SPI-flash erase timeout
......................................................................
Patch Set 1:
(1 comment)
Should the time-outs be unified?
https://review.coreboot.org/c/coreboot/+/34173/1/src/southbridge/intel/commo...
File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/c/coreboot/+/34173/1/src/southbridge/intel/commo...
PS1, Line 730: uint32_t timeout = 1000 * 200;
The function signature takes an unsigned integer.
src/southbridge/intel/common/spi.c:static int ich_hwseq_wait_for_cycle_complete(unsigned int timeout,
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34173
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id50636f9ed834ffd7810946798b300e58b2c14d2
Gerrit-Change-Number: 34173
Gerrit-PatchSet: 1
Gerrit-Owner: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 09 Jul 2019 14:23:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment