12 Jun
2019
12 Jun
'19
6:35 p.m.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33427 )
Change subject: hatch: Fix pen eject polarity ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33427/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/hatch/overridetree.cb:
https://review.coreboot.org/#/c/33427/1/src/mainboard/google/hatch/variants/... PS1, Line 89: register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)" Maybe we set EDGE_HIGH here and let kernel set as both? I think this active high actually. You can found our experiment in issue.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33427
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0816ed9fb23cf00fd8e40bcdd25ff7a9f48badbd
Gerrit-Change-Number: 33427
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 12 Jun 2019 16:35:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment