Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73231 )
Change subject: soc/amd/*/acpi: add comment about p_lvl[2,3]_lat FADT field usage ......................................................................
Patch Set 2:
(12 comments)
File src/soc/amd/cezanne/acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171158): https://review.coreboot.org/c/coreboot/+/73231/comment/57f678f8_ecaae13f PS2, Line 79: /* p_lvl2_lat and p_lvl3_lat match what the AGESA code does, but those vaules are 'vaules' may be misspelled - perhaps 'values'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171158): https://review.coreboot.org/c/coreboot/+/73231/comment/63c939da_4e03b305 PS2, Line 80: overridded by the _CST packages in the processor devices. */ 'overridded' may be misspelled - perhaps 'overridden'?
File src/soc/amd/glinda/acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171158): https://review.coreboot.org/c/coreboot/+/73231/comment/17507496_1c1d7431 PS2, Line 82: /* p_lvl2_lat and p_lvl3_lat match what the AGESA code does, but those vaules are 'vaules' may be misspelled - perhaps 'values'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171158): https://review.coreboot.org/c/coreboot/+/73231/comment/357dbfda_e02da57d PS2, Line 83: overridded by the _CST packages in the processor devices. */ 'overridded' may be misspelled - perhaps 'overridden'?
File src/soc/amd/mendocino/acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171158): https://review.coreboot.org/c/coreboot/+/73231/comment/f8773214_fea3eae0 PS2, Line 81: /* p_lvl2_lat and p_lvl3_lat match what the AGESA code does, but those vaules are 'vaules' may be misspelled - perhaps 'values'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171158): https://review.coreboot.org/c/coreboot/+/73231/comment/779b2727_eddb6dc2 PS2, Line 82: overridded by the _CST packages in the processor devices. */ 'overridded' may be misspelled - perhaps 'overridden'?
File src/soc/amd/phoenix/acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171158): https://review.coreboot.org/c/coreboot/+/73231/comment/d4d791be_c6313879 PS2, Line 82: /* p_lvl2_lat and p_lvl3_lat match what the AGESA code does, but those vaules are 'vaules' may be misspelled - perhaps 'values'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171158): https://review.coreboot.org/c/coreboot/+/73231/comment/87db490e_05b7dde7 PS2, Line 83: overridded by the _CST packages in the processor devices. */ 'overridded' may be misspelled - perhaps 'overridden'?
File src/soc/amd/picasso/acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171158): https://review.coreboot.org/c/coreboot/+/73231/comment/884f0cfd_9b1f2f06 PS2, Line 85: /* p_lvl2_lat and p_lvl3_lat match what the AGESA code does, but those vaules are 'vaules' may be misspelled - perhaps 'values'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171158): https://review.coreboot.org/c/coreboot/+/73231/comment/af1a1eb3_6ce215f0 PS2, Line 86: overridded by the _CST packages in the processor devices. */ 'overridded' may be misspelled - perhaps 'overridden'?
File src/soc/amd/stoneyridge/acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171158): https://review.coreboot.org/c/coreboot/+/73231/comment/bab4f8d7_23ff4c5f PS2, Line 77: /* p_lvl2_lat and p_lvl3_lat match what the AGESA code does, but those vaules are 'vaules' may be misspelled - perhaps 'values'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171158): https://review.coreboot.org/c/coreboot/+/73231/comment/cdddc718_f2e3260e PS2, Line 78: overridded by the _CST packages in the PSTATE SSDT. */ 'overridded' may be misspelled - perhaps 'overridden'?