Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31317 )
Change subject: google/kahlee: No need to guard with HAVE_ACPI_RESUME
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/31317/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31317/1//COMMIT_MSG@7
PS1, Line 7: google/kahlee: No need to guard with HAVE_ACPI_RESUME
Maybe:
Remove unneeded HAVE_ACPI_RESUME guard
https://review.coreboot.org/#/c/31317/1//COMMIT_MSG@8
PS1, Line 8:
Add a small note, why it’s not needed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31317
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8748ccddc8e31569c58deba5d08c98a04326fa8
Gerrit-Change-Number: 31317
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshall.dawson@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 11 Feb 2019 13:30:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment