David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40686 )
Change subject: mb/google/volteer: Create trondo variant
......................................................................
Patch Set 4:
(3 comments)
File src/mainboard/google/volteer/variants/trondo/gpio.c:
https://review.coreboot.org/c/coreboot/+/40686/comment/c77330ca_f2397633
PS4, Line 13: variant_base_gpio_table
This will cause NO gpio's to get configured. Is that what you intended to do? […]
Please refer to the CL.https://review.coreboot.org/c/coreboot/+/54274
https://review.coreboot.org/c/coreboot/+/40686/comment/0a727a19_62723e75
PS4, Line 24: variant_early_gpio_table
Defining this without having any early gpios defined will bypass the setting of the early gpio's in […]
Please refer to the CL.https://review.coreboot.org/c/coreboot/+/54274
https://review.coreboot.org/c/coreboot/+/40686/comment/cb86b548_40f4d413
PS4, Line 33: variant_cros_gpios
Same concept here. This will make it so that NO cros_gpios are defined.
Please refer to the CL.https://review.coreboot.org/c/coreboot/+/54274
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40686
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4f9bfe4798e14f91c6cb439f5c5ab2b9ea52b51
Gerrit-Change-Number: 40686
Gerrit-PatchSet: 4
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Alex Levin
levinale@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 13 May 2021 12:08:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment