Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46650 )
Change subject: soc/intel/xeon_sp/cpx: Set SLEEP_BUTTON flag in ACPI FADT
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
ACPI spec agrees.
https://review.coreboot.org/c/coreboot/+/46650/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46650/1//COMMIT_MSG@9
PS1, Line 9: no sleep button
nit: no sleep button *is present* on
https://review.coreboot.org/c/coreboot/+/46650/1//COMMIT_MSG@10
PS1, Line 10: Copperlake
nit: Co*o*perlake
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46650
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I268c178dfc094299ea6ec239aa1a7c82ccdb0410
Gerrit-Change-Number: 46650
Gerrit-PatchSet: 1
Gerrit-Owner: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 22 Oct 2020 07:26:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment