[coreboot-gerrit] [L] Change in coreboot[master]: allocator_v4: Use memranges only for toplevel

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Arthur Heymans, Bill XIE, Nico Huber, Eric Lai, Werner Zeh, Kyösti Mälkki.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65420 )

Change subject: allocator_v4: Use memranges only for toplevel
......................................................................

Patch Set 8: Code-Review+2

(2 comments)

Patchset:

PS8: 
I think this needs a rebase now

File src/device/resource_allocator_v4.c:

https://review.coreboot.org/c/coreboot/+/65420/comment/9cc50639_8647ee0c 
PS7, Line 437: void assign_resource_cb(void *param, struct device *dev, struct resource *res)
             : 	{
             : 		/* We have to filter the same resources as update_bridge_resource(). */
             : 		if (!res->size || !res->limit)
             : 			return;
             : 
             : 		assign_resource(res, *(const resource_t *)param + res->base, dev);
             : 	}
> More or less common practice in Ada ;) with very similar semantics, now that […]

I think it's OK; I think we could probably actually this technique a little more if we so wanted, it's not terribly hard to understand as long as there is no use of what would look like captured variables.