Attention is currently required from: Arthur Heymans, Bill XIE, Nico Huber, Eric Lai, Werner Zeh, Kyösti Mälkki.

Patch set 8:Code-Review +2

View Change

2 comments:

• Patchset:

  • Patch Set #8:

    I think this needs a rebase now

• File src/device/resource_allocator_v4.c:

  • Patch Set #7, Line 437:

    void assign_resource_cb(void *param, struct device *dev, struct resource *res)
    	{
    		/* We have to filter the same resources as update_bridge_resource(). */
    		if (!res->size || !res->limit)
    			return;
    
    		assign_resource(res, *(const resource_t *)param + res->base, dev);
    	}
    

    More or less common practice in Ada ;) with very similar semantics, now that […]

    I think it's OK; I think we could probably actually this technique a little more if we so wanted, it's not terribly hard to understand as long as there is no use of what would look like captured variables.

To view, visit change 65420. To unsubscribe, or for help writing mail filters, visit settings.