Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40339 )
Change subject: soc/amd/picasso: Use S-number in SMI handler ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40339/1/src/soc/amd/picasso/smihand... File src/soc/amd/picasso/smihandler.c:
https://review.coreboot.org/c/coreboot/+/40339/1/src/soc/amd/picasso/smihand... PS1, Line 157: slp_typ If the enum had a type and the values were documented, there would be no confusion on what the values mean.
https://review.coreboot.org/c/coreboot/+/40339/1/src/soc/amd/picasso/smihand... PS1, Line 162: slp_typ I would rather read the enum.