Attention is currently required from: Raul Rangel, Martin Roth, Eric Peers, Karthik Ramasubramanian.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55148 )
Change subject: mb/google/guybrush/var/guybrush: Update GPIO configuration
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55148/comment/fa86a316_5de60e57
PS1, Line 14: TP183
Looks like this was configured as NF (SPI_CS3_L)?
File src/mainboard/google/guybrush/variants/guybrush/gpio.c:
https://review.coreboot.org/c/coreboot/+/55148/comment/c78f112c_44a0a1e6
PS1, Line 14: HIGH
This was set to LOW because of the incorrect voltage rating. Is it safe to set it to HIGH here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55148
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31523b3e03d2b59577f33eae548747834cfc98aa
Gerrit-Change-Number: 55148
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 03 Jun 2021 02:31:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment