Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38081 )
Change subject: mb/hp/*/devicetree.cb: Inherit the subsystemid ......................................................................
Patch Set 1: Code-Review-1
(4 comments)
Not sure if it's necessary to check OS drivers if they are affected by SID changes... but the changes should be properly documented in the commit message at least. If unsure, build and compare `static.c`.
https://review.coreboot.org/c/coreboot/+/38081/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38081/1//COMMIT_MSG@9 PS1, Line 9: Since the same subsystemid is used for all the devices on the This is not true, some were left at their default.
https://review.coreboot.org/c/coreboot/+/38081/1/src/mainboard/hp/2760p/devi... File src/mainboard/hp/2760p/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38081/1/src/mainboard/hp/2760p/devi... PS1, Line 78: device pci 1c.3 on end # WLAN Didn't have a subsystem id before.
https://review.coreboot.org/c/coreboot/+/38081/1/src/mainboard/hp/2760p/devi... PS1, Line 81: device pci 1c.6 on end # PCIe Port #7, WWAN Didn't either.
https://review.coreboot.org/c/coreboot/+/38081/1/src/mainboard/hp/8770w/devi... File src/mainboard/hp/8770w/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38081/1/src/mainboard/hp/8770w/devi... PS1, Line 36: device pci 00.0 on end # GPU : device pci 00.1 on end # HDMI Audio on GPU Note, these inherit the sid too, intended?