Not sure if it's necessary to check OS drivers if they are
affected by SID changes... but the changes should be properly
documented in the commit message at least. If unsure, build
and compare `static.c`.

Patch set 1:Code-Review -1

View Change

4 comments:

• Commit Message:

  • Patch Set #1, Line 9: Since the same subsystemid is used for all the devices on the

    This is not true, some were left at their default.

• File src/mainboard/hp/2760p/devicetree.cb:

  • Patch Set #1, Line 78: device pci 1c.3 on end # WLAN

    Didn't have a subsystem id before.

  • Patch Set #1, Line 81: device pci 1c.6 on end # PCIe Port #7, WWAN

    Didn't either.

• File src/mainboard/hp/8770w/devicetree.cb:

  • Patch Set #1, Line 36:

    			device pci 00.0 on  end	# GPU
    			device pci 00.1 on  end	# HDMI Audio on GPU
    

    Note, these inherit the sid too, intended?

To view, visit change 38081. To unsubscribe, or for help writing mail filters, visit settings.