Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36561 )
Change subject: lib/imd: Use uintptr_t over void * ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36561/8/src/lib/imd.c File src/lib/imd.c:
https://review.coreboot.org/c/coreboot/+/36561/8/src/lib/imd.c@545 PS8, Line 545: low_addr = (uintptr_t)r + e->start_offset; relative pointer was utilizing intptr_t where now you are making this a uinptr_t. It probably doesn't matter in many of our situations, but we should be consistent and cast to intptr_t in the expression? start_offset is signed so it should sign extend on the implicit conversion if the type sizes are different.