Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Sumeet R Pawnikar.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81676?usp=email )
Change subject: mb/google/brya: Remove baseboard-specific FMD names
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81676/comment/aa39d2ed_6a604364 :
PS2, Line 11: Additionally, this patch removes the Nissa-specific
: 32MB FMD file, as the Nissa board only uses a 16MB SPI flash.
i guess you said that some Nissa variant also uses 32MB fmd file ? so, better we call out here that […]
Commit message updaed and boot verified the 32MB unified FMD on nivviks.
https://review.coreboot.org/c/coreboot/+/81676/comment/761cef7f_15365978 :
PS2, Line 14:
please create a bug id for trulo baseboard support and use that here.
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81676?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9151a4bcbe9cc084cc19b1a3e91c0321fe4dcc37
Gerrit-Change-Number: 81676
Gerrit-PatchSet: 3
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 08 Apr 2024 07:12:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment