Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41680 )
Change subject: soc/intel/xeon_sp: Early programming of ACPI bar ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/c/coreboot/+/41680/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41680/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/xeon_sp: Early programming of ACPI bar
Please make that a statement by adding a verb (in imperative mood). Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/41680/1//COMMIT_MSG@12 PS1, Line 12: checked
check
Done
https://review.coreboot.org/c/coreboot/+/41680/1//COMMIT_MSG@13 PS1, Line 13: status registers
Any changes in the log messages?
Done...added more information for log.
https://review.coreboot.org/c/coreboot/+/41680/3/src/soc/intel/xeon_sp/inclu... File src/soc/intel/xeon_sp/include/soc/bootblock.h:
https://review.coreboot.org/c/coreboot/+/41680/3/src/soc/intel/xeon_sp/inclu... PS3, Line 3: _SOC_SKYLAKE_BOOTBLOCK_H_
not nice […]
Ack
https://review.coreboot.org/c/coreboot/+/41680/3/src/soc/intel/xeon_sp/inclu... PS3, Line 8: /* Bootblock pre console init programming */ : void bootblock_cpu_init(void); : void bootblock_pch_early_init(void); : : /* Bootblock post console init programming */ : void i2c_early_init(void);
In this patch, only the bootblock_pch_init function is added, others aren't needed.
Ack
https://review.coreboot.org/c/coreboot/+/41680/3/src/soc/intel/xeon_sp/inclu... PS3, Line 15: void pch_early_iorange_init(void); : void report_platform_info(void); : void report_memory_config(void);
Do we really need these function now?
Ack