Attention is currently required from: Ccong Chen, Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Ccong Chen. ( https://review.coreboot.org/c/coreboot/+/85599?usp=email )
Change subject: soc/meidatek/mt8196: Add SPM loader
......................................................................
Patch Set 8:
(3 comments)
File src/soc/mediatek/common/spm.c:
https://review.coreboot.org/c/coreboot/+/85599/comment/da50a50c_3444638e?usp... :
PS1, Line 59: #ifndef CONFIG_MEDIATEK_SPM_V2
No done
Done
https://review.coreboot.org/c/coreboot/+/85599/comment/49adc530_c59ba8ff?usp... :
PS1, Line 101: CONFIG_MEDIATEK_SPM_V2
not done
Done
File src/soc/mediatek/common/spm.c:
https://review.coreboot.org/c/coreboot/+/85599/comment/029b1f1d_a05fd73f?usp... :
PS8, Line 30: ptr = (uintptr_t)pcm->buf + SPM_SYSTEM_BASE_OFFSET;
Define SPM_SYSTEM_BASE_OFFSET as 0 in the header file. There's no need to change this.
Remove the newly added Kconfig. It's not needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85599?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie09346f46cb734c74776b760485e7f35d4357e5e
Gerrit-Change-Number: 85599
Gerrit-PatchSet: 8
Gerrit-Owner: Ccong Chen
ot_ccong.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jarried Lin
jarried.lin@mediatek.com
Gerrit-CC: Wenzhen Yu
wenzhen.yu@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Ccong Chen
ot_ccong.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Thu, 19 Dec 2024 13:21:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ccong Chen
ot_ccong.chen@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com