[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Check if CSE is function disable

[Subrata Banik (Code Review)]

Attention is currently required from: Tim Wawrzynczak, Sridhar Siricilla, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58513 )

Change subject: soc/intel/common: Check if CSE is function disable
......................................................................

Patch Set 3:

(1 comment)

File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/58513/comment/a0e8c1de_33780d36 
PS3, Line 251: /*
             : 	 * If ME is already hidden then reading ME HFS1 register would be wrong and will
             : 	 * receive junk, hence, return `true` as CSE is already disable.
             : 	 */
             : 	if (!is_cse_enabled())
             : 		return true;
> I had little different opinion about leaving things on caller side because in API world we should tr […]

Just that I would like to understand the motivation behind 2nd option where caller takes care of the additional check. 
Can you please share thoughts on this?
> > Caller should check CSE enable status before calling the APIs which deal with CSE

Are you thinking to add a check for `is_cse_enabled()` here at 
https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/block/... ?

or

https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/block/... ?