Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30891 )
Change subject: console: Change BOOTBLOCK_CONSOLE default to `y` ......................................................................
Patch Set 3:
(1 comment)
I think we should ask ourselves why we have this option in the first place. I don't think it's really meant primarily as a user control... because I don't really see how that would be that useful (when do you really ever want output from romstage but not from the bootblock?), and if we wanted that we should probably have a more consistent set of options to decide it for each stage.
Yeah, don't think it's useful either. I'm starting to believe that the people that add all these Kconfig prompts just didn't understand the syntax. I wouldn't mind at all to remove the prompt.
https://review.coreboot.org/#/c/30891/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30891/3//COMMIT_MSG@13 PS3, Line 13: samsung/exynos5420
IIRC this was intentional, because there was some bug on 5420 that made it hang when you tried to us […]
You are right. I thought BOOTBLOCK_CONSOLE was much older than exynos5420 but it turned out that the commit message adding the former reasons about it: "[...] but on the 5420 it only starts working in the ROM stage after clocks have been initialized.". CB:30926
Somehow weird that the same commit that reasons about the breakage adds the option to break it.