[coreboot-gerrit] Change in coreboot[master]: mb/google/kukui: Support SKU from camera EEPROM

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45811 )

Change subject: mb/google/kukui: Support SKU from camera EEPROM
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45811/2/src/mainboard/google/kukui/... 
File src/mainboard/google/kukui/boardid.c:

https://review.coreboot.org/c/coreboot/+/45811/2/src/mainboard/google/kukui/... 
PS2, Line 142: check_cros_camera_info
> When CONFIG(BOARD_GOOGLE_KODAMA), shouldn't CONFIG(CHROMEOS) also be 1? I can run

No. The kukui/Kconfig only sets MAINBOARD_HAS_CHROMEOS.
And CHROMEOS is default n (that it'll be set to y if we're building with emerge)
> util/abuild/abuild -c max -t GOOGLE_KODAMA -x

But I think the CQ failed when building without CHROMEOS