Hello Aaron Durbin, Patrick Rudolph, Julius Werner, Subrata Banik, Duncan Laurie, Paul Menzel, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35076
to look at the new patch set (#5).
Change subject: drivers/spi/acpi: Support power resource as parent in device tree ......................................................................
drivers/spi/acpi: Support power resource as parent in device tree
This allows supporting an independent power resource for SPI ACPI devices, so that the power resource configuration can be refactored out of individual drivers and coalesced into a separate one.
device pci 00.0 on chip drivers/spi/acpi register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO0)" register "reset_enable_delay_ms" = "100" ... device spi 1 on end end
chip drivers/spi/acpi register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO0)" register "reset_enable_delay_ms" = "2" ... device spi 2 on end end end
You can then write:
device pci 00.0 on chip drivers/generic/power_resource register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO0)" register "reset_enable_delay_ms" = "100" device generic 0 on chip drivers/spi/acpi register ... device spi 1 on end end chip drivers/spi/acpi register ... device spi 2 on end end end end end
Change-Id: Ib1e52a0f31d430637c9d819e231f9c4af6c68672 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/drivers/spi/acpi/acpi.c 1 file changed, 20 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/35076/5