Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44283 )
Change subject: mb/intel/jasperlake_rvp: Re-organize the flash map layout ......................................................................
Patch Set 2: Code-Review+2
Patch Set 2:
This CL has got nothing to do with the build failure in havlor(pasted below). Is it possible to re-run the build bot. May be there is some flakiness?
CC romstage/mainboard/google/volteer/variants/halvor/memory.o
src/mainboard/google/volteer/variants/halvor/memory.c:57:27: error: conflicting types for 'variant_memory_params' const struct lpddr4x_cfg *variant_memory_params(void) ^~~~~~~~~~~~~~~~~~~~~ In file included from src/mainboard/google/volteer/variants/halvor/memory.c:3: src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h:21:30: note: previous declaration of 'variant_memory_params' was here const struct ddr_memory_cfg *variant_memory_params(void); ^~~~~~~~~~~~~~~~~~~~~ cc1: error: unrecognized command line option '-Wno-address-of-packed-member' [-Werror] cc1: all warnings being treated as errors make[1]: *** [Makefile:362: /cb-build/coreboot-gerrit.0/default/GOOGLE_HALVOR/romstage/mainboard/google/volteer/variants/halvor/memory.o] Error 1
That error is definitely unrelated. Two commits were submitted, CB:44249 which changed the signature of `variant_memory_params`, and CB:43988 which introduced a new instance using the old signature. This broke master. Once CB:43076 was submitted, Jenkins was happy again.