Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47719 )
Change subject: mb/google/zork: Remove 50ms WIFI delay ......................................................................
Patch Set 1:
(2 comments)
the code looks good to me
https://review.coreboot.org/c/coreboot/+/47719/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/47719/1/src/mainboard/google/zork/v... PS1, Line 203: * - Deassert WIFI_AUX_RESET_L in mainboard_configure_gpios "WIFI_AUX_RESET_L gets deasserted later in mainboard_configure_gpios in ramstage" maybe?
https://review.coreboot.org/c/coreboot/+/47719/1/src/mainboard/google/zork/v... PS1, Line 276: __weak void variant_pcie_gpio_configure(void) out of scope for this patch, but i'd like this function to be renamed to variant_pcie_early_gpio_configure or similar so that it's clearer from the function name that this is the part of the gpio setup that's done in bootblock