Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73205 )
Change subject: soc/amd/mendocino: Add STT support for dptc tablet mode ......................................................................
soc/amd/mendocino: Add STT support for dptc tablet mode
Add stt settings for dptc tablet mode.
BUG=b:257149501 BRANCH=None TEST=Check if the STT value matches the clamshell/tablet mode. Run the WebGL aquarium with 5000 fish and verify that there is no power drop peak.
Change-Id: Ib4aad3af8761b20084717b15a462edf4704b83cc Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/73205 Reviewed-by: Tim Van Patten timvp@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frank Wu frank_wu@compal.corp-partner.google.com --- M src/soc/amd/mendocino/chip.h M src/soc/amd/mendocino/root_complex.c 2 files changed, 30 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Frank Wu: Looks good to me, approved Tim Van Patten: Looks good to me, approved
diff --git a/src/soc/amd/mendocino/chip.h b/src/soc/amd/mendocino/chip.h index dc147f8..42f27cb 100644 --- a/src/soc/amd/mendocino/chip.h +++ b/src/soc/amd/mendocino/chip.h @@ -73,6 +73,10 @@ uint32_t vrm_soc_current_limit_throttle_mA;
/* tablet mode.*/ + uint16_t stt_m1_tablet; + uint16_t stt_m2_tablet; + uint16_t stt_c_apu_tablet; + uint16_t stt_alpha_apu_tablet;
/* Thermal profile B*/ uint32_t fast_ppt_limit_mW_B; diff --git a/src/soc/amd/mendocino/root_complex.c b/src/soc/amd/mendocino/root_complex.c index dce9498..6217246 100644 --- a/src/soc/amd/mendocino/root_complex.c +++ b/src/soc/amd/mendocino/root_complex.c @@ -264,10 +264,10 @@ config->vrm_maximum_current_limit_mA, config->vrm_soc_current_limit_mA, config->stt_min_limit, - config->stt_m1, - config->stt_m2, - config->stt_c_apu, - config->stt_alpha_apu, + config->stt_m1_tablet, + config->stt_m2_tablet, + config->stt_c_apu_tablet, + config->stt_alpha_apu_tablet, config->stt_skin_temp_apu); acpigen_write_alib_dptc_tablet((uint8_t *)&tablet_input, sizeof(tablet_input)); #endif