Attention is currently required from: Arthur Heymans, Nico Huber.
Angel Pons has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/coreboot/+/64197?usp=email )
Change subject: haswell NRI: Add write leveling ......................................................................
Patch Set 9:
(2 comments)
File src/northbridge/intel/haswell/native_raminit/train_jedec_write_leveling.c:
https://review.coreboot.org/c/coreboot/+/64197/comment/6833ec07_5e74900d?usp... : PS9, Line 191: pass This should be called `fail` - there's a few other things I would like to clean up but I'd rather take care of them in a follow-up since I would need to test them on hardware.
https://review.coreboot.org/c/coreboot/+/64197/comment/b76bf0fe_4f79c4e2?usp... : PS9, Line 193: if (skip_me & BIT(byte))
`Too many leading tabs - consider code refactoring`
Problem is that there's lots of nested loops. I thought about extracting the inner loop to a separate function, but then I'd have to pass about half a dozen parameters (`channel, byte, off, skip_me, byte_pass, byte_off, byte_sum`), and the function signature would be awful.