Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43467 )
Change subject: mb/google/zork: Don't generate power resource for Raydium TS
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43467/4/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/dalboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43467/4/src/mainboard/google/zork/v...
PS4, Line 55: register "reset_delay_ms" = "20"
Or did you mean that we are exposing reset_gpio and that code doesn't meet the condition you linked. […]
Oh. has_power_resource also controls _ON/_OFF generation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43467
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23131be5d7109eed660a8bd6e2c156c015aa3c4e
Gerrit-Change-Number: 43467
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 14 Jul 2020 23:50:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment