Attention is currently required from: Angel Pons, Krystian Hebel, Michał Kopeć, Michał Żygowski, Nico Huber.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69900?usp=email )
Change subject: soc/intel/apollolake/include/soc/pmc.h: Add file
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69900/comment/32adcfc0_d9ad9db6 :
PS5, Line 10: pm.h
Ping
An alternative to the empty file would be to move the PMC related code from pm.h to this file. You might need to add the include of pmc.h to some files, but those would all be pretty easy to find.
If you don't like that, I'd say go ahead and create the empty file. Maybe put a comment in stating that all the #defines needed are in pm.h.
Thoughts?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69900?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2726aaae1ce60d15a3944dadcf793def2dcb3a1c
Gerrit-Change-Number: 69900
Gerrit-PatchSet: 7
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Mon, 07 Aug 2023 20:40:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment