V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47431 )
Change subject: soc/intel/common: Generate the CSE RW metadata and add to FW_MAIN_A/B
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47431/7/src/soc/intel/common/block/...
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/47431/7/src/soc/intel/common/block/...
PS7, Line 79: cse_rw_metadata
Can you rename "struct cse_rw_metadata" to "struct cse_cbfs_rw_info" to indicate the metadata is of […]
I would suggest you to use to use the same structure name and also the name is justified since it contains the CSE RW metadata (version and hash).
This structure is also used the cse_rw_metadata.c file and hash/version is updated by makefile.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47431
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I412581400a9606fa17cf4398faffda923f07b320
Gerrit-Change-Number: 47431
Gerrit-PatchSet: 7
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Comment-Date: Wed, 11 Nov 2020 16:38:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment