Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47039 )
Change subject: mb/google/volteer/var/elemi: Update gpio and devicetree
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47039/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/elemi/gpio.c:
https://review.coreboot.org/c/coreboot/+/47039/3/src/mainboard/google/voltee...
PS3, Line 189: /* B2 : VRALERT# ==> EN_PP3300_SSD */
: PAD_CFG_GPO(GPP_B2, 1, DEEP),
: /* B4 : CPU_GP3==> EN_PP3300_EMMC */
: PAD_CFG_GPO(GPP_B4, 1, DEEP),
Remove it and check it can boot into SSD.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47039
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b8880d485ed73aa4e65c1249c58f02c8f0c6501
Gerrit-Change-Number: 47039
Gerrit-PatchSet: 4
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 03 Nov 2020 17:47:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Chen Wisley
wisley.chen@quantatw.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment