Jitao Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )
Change subject: mb/google/kukui: Enable Eotp feature for anx7625 ......................................................................
Patch Set 9:
(5 comments)
https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG@7 PS8, Line 7: enable
Enable
Will fix next version.
https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG@9 PS8, Line 9: Enable Eotp feature for anx7625.
What does EOTP do?
EoTp is End of Transmission packet (EoTp) defined in dsi spec.
https://review.coreboot.org/c/coreboot/+/48868/8//COMMIT_MSG@13 PS8, Line 13: TEST=Boots correctly on Kukui
What changed? How do you verify EOTP works? As new print statements are added, maybe also paste that […]
We test it with dsi protocol tool. The protocol tool can receiver the EoTp packet.
https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/... PS8, Line 163: if (CONFIG(DRIVER_ANALOGIX_ANX7625)) : mipi_dsi_flags |= MIPI_DSI_MODE_EOT_PACKET;
please refer to https://chromium-review.googlesource. […]
Yes, you are right.
The comment lets me misunderstood the "MIPI_DSI_MODE_EOT_PACKET". /* disable EoT packets in HS mode */ MIPI_DSI_MODE_EOT_PACKET = BIT(9),
I'll correct the wrong setting in soc dsi.
https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/... PS8, Line 170: printk(BIOS_INFO, "%s: dsi_flags=%#x\n", __func__, mipi_dsi_flags);
Looks more like debug information. Otherwise, please rephrase to be better understandable.
Yes, this is debug info.
I'll remove next patchset.