build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38981 )
Change subject: xeonsp/skylake-sp: Add FSP SiliconInit invocation
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38981/9/src/cpu/intel/xeonsp/cpu/sk...
File src/cpu/intel/xeonsp/cpu/skylake-sp/chip.c:
https://review.coreboot.org/c/coreboot/+/38981/9/src/cpu/intel/xeonsp/cpu/sk...
PS9, Line 70: if (dev->path.type == DEVICE_PATH_DOMAIN) {
braces {} are not necessary for any arm of this statement
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38981
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e5eeb580207aa7c3d3ab02a3321b658e63c95d0
Gerrit-Change-Number: 38981
Gerrit-PatchSet: 9
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 21 Feb 2020 21:06:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment