Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44740 )
Change subject: soc/intel/cnl: Allow enabling/disabling Chap device
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44740/14/src/soc/intel/cannonlake/f...
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/44740/14/src/soc/intel/cannonlake/f...
PS14, Line 532: tconfig->ChapDeviceEnable = is_dev_enabled(dev);
FSP header doesn't seem to mention which value actually enables it. Please
confirm that the default in the binaries is indeed 0.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44740
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I177c2dc91a507cc633b024cf388bcc97e0d0f2e6
Gerrit-Change-Number: 44740
Gerrit-PatchSet: 14
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 22 Sep 2020 18:52:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment