Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46662 )
Change subject: soc/intel/xeon_sp/skx: Add missing includes
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46662/1/src/soc/intel/xeon_sp/skx/c...
File src/soc/intel/xeon_sp/skx/cpu.c:
https://review.coreboot.org/c/coreboot/+/46662/1/src/soc/intel/xeon_sp/skx/c...
PS1, Line 11: #include <soc/soc_util.h>
: #include <soc/util.h>
these includes really don't have good names. No wonder stuff like this is happening.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46662
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ef9b416b52a6a1275d699708a805d4ba49baef0
Gerrit-Change-Number: 46662
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 23 Oct 2020 00:42:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment