Duncan Laurie has uploaded a new patch set (#13) to the change originally created by Keith Short. ( https://review.coreboot.org/c/coreboot/+/32777 )
Change subject: ec/google/wilco: set diagnostic LEDs on boot failure ......................................................................
ec/google/wilco: set diagnostic LEDs on boot failure
On Wilco devices, if any of the coreboot stages fails with a fatal error, set the diagnostic LEDs with the Wilco EC. The last saved post code is used to determine the error code sent to the EC.
BUG=b:124401932 BRANCH=sarien TEST=build coreboot for sarien and arcada platforms TEST=Remove DIMM module, confirm diagnostic LED pattern for memory failure (2 amber, 4 white). TEST=Forced a fatal error in both bootblock and verstage to confirm diagnostic LEDs during these stages. This works on cold-boots only. Bug b:132622888 tracks the mailbox failures on warm boots.
Change-Id: If865ab8203f89e499130f4677fec166b40d80174 Signed-off-by: Keith Short keithshort@chromium.org Signed-off-by: Duncan Laurie dlaurie@google.com --- M src/ec/google/wilco/commands.c M src/ec/google/wilco/commands.h 2 files changed, 52 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/32777/13