William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39857 )
Change subject: mb/google/volteer: Create Malefor variant ......................................................................
Patch Set 6: Code-Review+1
(6 comments)
https://review.coreboot.org/c/coreboot/+/39857/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/gpio.c:
https://review.coreboot.org/c/coreboot/+/39857/5/src/mainboard/google/voltee... PS5, Line 10: gpio_table
Is this gpio_table just a complete copy of ripto/volteer? Or is this updated to handle malefor? If i […]
This table compatible with malefor board, not just a copy.
https://review.coreboot.org/c/coreboot/+/39857/5/src/mainboard/google/voltee... PS5, Line 405: early_gpio_table
Same comment as above.
It's the same table with baseboard, I'll remove them.
https://review.coreboot.org/c/coreboot/+/39857/5/src/mainboard/google/voltee... PS5, Line 446: cros_gpios
Same comment as above.
It's the same table with baseboard, I'll remove them.
https://review.coreboot.org/c/coreboot/+/39857/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/memory.c:
https://review.coreboot.org/c/coreboot/+/39857/5/src/mainboard/google/voltee... PS5, Line 8: baseboard
This is not really baseboard. […]
I'll change the structure name to malefor. Thanks for you suggestion!
https://review.coreboot.org/c/coreboot/+/39857/5/src/mainboard/google/voltee... PS5, Line 39: __weak
Why is this weak?
Sorry, I missed remove it..
https://review.coreboot.org/c/coreboot/+/39857/5/src/mainboard/google/voltee... PS5, Line 44: int variant_memory_sku(void) : { : gpio_t spd_gpios[] = { : GPIO_MEM_CONFIG_0, : GPIO_MEM_CONFIG_1, : GPIO_MEM_CONFIG_2, : GPIO_MEM_CONFIG_3, : }; : : return gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios)); : }
Is this different than what baseboard is providing?
It's same as baseboard's definition, so I'll remove them.