Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34006 )
Change subject: mb/google/hatch: Fix PRE-CBMEM console overflow issue ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34006/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34006/1//COMMIT_MSG@11 PS1, Line 11: issue.
I would rather only increase the default per platform. It doesn't have to be at the mainboard level (though, a mainboard can still override a platform default).
e.g. if this 0xe00 works for all Hatch variants, it should work for all mainboards with WHL/CML too.
make sense to me.
Before C_ENVIRONMENT_BOOTBLOCK, we had the problem that the console could conflict with the stack. I think that changed, however, so we could actually make the console as big as pos- sible on platforms with C_ENVIRONMENT_BOOTBLOCK (i.e. the linker should tell us if it's too big).