Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31727 )
Change subject: util/amdfwtool: Clarify calculations with structures
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31727/2/util/amdfwtool/amdfwtool.c
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/#/c/31727/2/util/amdfwtool/amdfwtool.c@809
PS2, Line 809: sizeof(embedded_firmware);
Since this is 24 bytes (0x18), i'm not sure this is right if we were expecting the following table t […]
Ok, and I see where this is updated in a later change with an alignment macro as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31727
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If05952d9282a0fa5a397984eaae671fb33f6134a
Gerrit-Change-Number: 31727
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Wed, 06 Mar 2019 23:20:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment