David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38221 )
Change subject: soc/amd/picasso: Drop forked copy of SMBus source ......................................................................
Patch Set 4:
Is this patch blocking anything important? I see a big patch chain of clean-up patches that have almost all been merged, so it seems progress is being made here. Why can't the common code be merged first with this as part of the chain?
Patch Set 4: Especially if the blocker is CB:33772, a commit that has not been touched in over a month and has never managed to build successfully.
That's misleading considering the time of year.
Marshall, as per the Gerrit guidelines, [1] I have to ask that you please remove your -2.
What part of that are you citing? Marshall has outlined the plan for resolving this and +2'd CB:38222. In his -2 he made a reasonable suggestion to merge the common code first before dropping this code, as to avoid breaking platform development that is underway.
The guidelines also say "Don’t submit patches that you know will break other platforms", though it's murky in this case since Picasso appears to be broken in its current state. If it were orphaned or obsolete hardware then the answer could simply be to remove it entirely. But since it's being actively developed, that is another matter.
While we're citing guidelines, the ad hominem attacks used in some of the later comments definitely fails to meet the threshold for respectful conduct.
Cleaning up APIs is certainly necessary and Kyösti's efforts here are appreciated. AFAICT nobody is against this patch, the only resistance is due to timing of platform development currently underway.