Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40383 )
Change subject: soc/intel/xeon_sp/cpx: fix MADT ACPI table
......................................................................
Patch Set 20:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40383/20/src/soc/intel/xeon_sp/cpx/...
File src/soc/intel/xeon_sp/cpx/acpi.c:
https://review.coreboot.org/c/coreboot/+/40383/20/src/soc/intel/xeon_sp/cpx/...
PS20, Line 191: int gsi_bases[] = { 0, 0x18, 0x20, 0x28, 0x30, 0x48, 0x50, 0x58, 0x60 };
define?
https://review.coreboot.org/c/coreboot/+/40383/20/src/soc/intel/xeon_sp/cpx/...
File src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/40383/20/src/soc/intel/xeon_sp/cpx/...
PS20, Line 75: #define VTD_DEV 5
one tab too much
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40383
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1bf6e39db545e227e9867aa8d24f7db1d820216
Gerrit-Change-Number: 40383
Gerrit-PatchSet: 20
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 04 Jun 2020 15:54:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment