Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42567 )
Change subject: soc/amd/picasso: Populate EFS SPI values from Kconfig options ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42567/5/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/42567/5/src/soc/amd/picasso/Kconfig... PS5, Line 369: SPI_READ_MODE_DUAL_IO_112 Is this a safe default for mandolin/cereme as well? Should we use SPI_READ_MODE_NORMAL_66M to be safe?
https://review.coreboot.org/c/coreboot/+/42567/5/src/soc/amd/picasso/Kconfig... PS5, Line 396: default Can you also add a `default SPI_SPEED_16M if EM100`
https://review.coreboot.org/c/coreboot/+/42567/5/src/soc/amd/picasso/Kconfig... PS5, Line 398: SPI_SPEED_66M If you wanted to be fancy you could add depends on !SPI_READ_MODE_NORMAL_33M
https://review.coreboot.org/c/coreboot/+/42567/5/src/soc/amd/picasso/Kconfig... PS5, Line 410: SPI_SPEED_100M depends on !SPI_READ_MODE_NORMAL_66M && !SPI_READ_MODE_NORMAL_33M