Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/29191 )
Change subject: mb/google/poppy: add the smi_events back
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/29191/1/src/mainboard/google/poppy/ec.c
File src/mainboard/google/poppy/ec.c:
https://review.coreboot.org/#/c/29191/1/src/mainboard/google/poppy/ec.c@27
PS1, Line 27: .smi_events = MAINBOARD_EC_SMI_EVENTS,
+Nick, can you please test this on a nocturne?
I've been working on verifying this change, but ran into build issues. I got around the build issue, working on verifying this change now.
--
To view, visit
https://review.coreboot.org/29191
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529
Gerrit-Change-Number: 29191
Gerrit-PatchSet: 4
Gerrit-Owner: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 23 Oct 2018 19:44:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No