Attention is currently required from: Rizwan Qureshi, Deepti Deshatty, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52183 )
Change subject: intel/common/block/tcss: Add a weak funtion for mainboard_tcss_get_port_info()
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
Patchset:
PS3:
It was intentional to not leave a weak function in place. I intended for the mainboard developer to add a `mainboard_tcss_get_port_info()` function in the same patch that they add SOC_INTEL_COMMON_BLOCK_TCSS
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52183
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ccc799f28d45f5ffd0e9b8179ed973744af8113
Gerrit-Change-Number: 52183
Gerrit-PatchSet: 3
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Deepti Deshatty
deepti.deshatty@intel.corp-partner.google.com
Gerrit-Attention: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 08 Apr 2021 14:25:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment