[coreboot-gerrit] Change in coreboot[master]: soc/intel/jasperlake: Disable PAVP UPD

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41763 )

Change subject: soc/intel/jasperlake: Disable PAVP UPD
......................................................................

Patch Set 4:
> Patch Set 4:
> > Patch Set 4:
> >
> > What is the reason for this change. All other platforms leave it
> > enabled why disable it for this one? Also, if it should be globally
> > disabled why not update the FSP binary?
> >
> > Please always mention the reason for a change in the commit message.
>
> In other platforms FSP default is 0. In JSL it is 1 so need to disable it from here.

Are you sure about this? A quick grep suggests otherwise:

$ git grep Enable\ PavpEnable -- $(git ls-files src/vendorcode/intel/fsp/*.h)
    src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspsUpd.h:  Enable(Default): Enable PavpEnable, Disable: Disable PavpEnable
    src/vendorcode/intel/fsp/fsp2_0/jasperlake/FspsUpd.h:  Enable(Default): Enable PavpEnable, Disable: Disable PavpEnable
    src/vendorcode/intel/fsp/fsp2_0/tigerlake/FspsUpd.h:  Enable(Default): Enable PavpEnable, Disable: Disable PavpEnable
    $ cd 3rdparty/fsp/
    $ git grep Enable\ PavpEnable -- $(git ls-files *.h)
    AmberLakeFspBinPkg/Include/FspsUpd.h:  Enable(Default): Enable PavpEnable, Disable: Disable PavpEnable
    CoffeeLakeFspBinPkg/Include/FspsUpd.h:  Enable(Default): Enable PavpEnable, Disable: Disable PavpEnable
    CometLakeFspBinPkg/CometLake1/Include/FspsUpd.h:  Enable(Default): Enable PavpEnable, Disable: Disable PavpEnable
    IceLakeFspBinPkg/Include/FspsUpd.h:  Enable(Default): Enable PavpEnable, Disable: Disable PavpEnable
    KabylakeFspBinPkg/Include/FspsUpd.h:  Enable(Default): Enable PavpEnable, Disable: Disable PavpEnable

Are all the comments wrong?